Implement new inputs and select components #46812
Conversation
bl-nero
force-pushed
the
bl-nero/inputs
branch
from
e2655c4
to
f53319d
Compare
|
@kimlisa The dropdowns gap is a separate issue that has been introduced before this PR. As for the non-hover icons, they were designed this way, so any feedback should go to Kenny and Rishi. :) |
|
@kiosion @ravicious @avatus Friendly ping |
do you know when it was introduced? |
public-teleport-github-review-bot
bot
removed request for
ravicious and
kiosion
@avatus Not yet. |
@avatus I didn't intend to backport this, as it (1) changes the look of the login dialog, and I'd like to reserve that for a major version upgrade, and (2) we want to maintain consistency with other design updates. I may backport the API change, similarly to how I backported the typography API changes without the actual design change before. I think the only change here is addition of the size attribute and renaming the label tip field to helper text. |
This change:
InputandFieldInputcomponentsSelect*andFieldSelect*family of components, including unifying the set of accepted properties and supported features between the components of the familyFigma: inputs, dropdowns
This is a large PR, so it's best to review it commit by commit. I decided to lump both input and select changes together, since they frequently appear together and testing these changes together saved a lot of time.
Caveats:
SelectCreatableinsideteleport/Discover/Shared/SelectCreatable, but I don't want to make this PR bigger than it already is.Fixes #46611
Needs to be merged together with https://github.com/gravitational/teleport.e/pull/5052.
Tested by inspecting all storybook entries and making sure that layouts are fine and don't break when they show validation errors. A couple of screens were also tested on the real Web and Connect UI.
Note: since this PR is the largest and latest of the highly-visible UI changes, it bears the changelog line; however, this has been gradually introduced to v17 across a multitude of PRs. To see the entire development history, see all subissues of #37260.
Changelog: Refreshed the Web and Teleport Connect UI design.